Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSP Websocket compatibility #6706

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Add CSP Websocket compatibility #6706

merged 1 commit into from
Nov 20, 2023

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Nov 15, 2023

Summary

This PR automatically adds Websocket source URLs to the content security policy of the Console and Account app.

Changes

  • Automatically add the ws/wss versions of the API base URLs to CSP.

Testing

Unit testing, and also cherry-picked into https://github.com/TheThingsIndustries/lorawan-stack/pull/3953 in order to check with staging1.

Regressions

N/A. The tests cover the behavior. No dedicated testing is required.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.1 milestone Nov 15, 2023
@adriansmares adriansmares self-assigned this Nov 15, 2023
@github-actions github-actions bot added c/console This is related to the Console c/identity server This is related to the Identity Server ui/web This is related to a web interface labels Nov 15, 2023
@KrishnaIyer KrishnaIyer modified the milestones: v3.28.1, v3.28.2 Nov 20, 2023
@adriansmares adriansmares merged commit 7344e93 into v3.28 Nov 20, 2023
12 of 13 checks passed
@adriansmares adriansmares deleted the feature/csp-fix branch November 20, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console c/identity server This is related to the Identity Server ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants