Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.21 #6687

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Use Go 1.21 #6687

merged 3 commits into from
Nov 3, 2023

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Nov 3, 2023

Summary

This PR upgrades our stack to be built using Go 1.21.

Changes

  • Use Go 1.21 in go.mod and CI.
  • Use standard slices package instead of experimental one.
  • Use standard maps package instead of experimental one, mostly.
    • Keys and Values have been removed last moment from the 1.21 release, and will be added back in a future version.

Testing

CI. No explicit testing is required.

Regressions

Based on my reading of the 1.21 changelog, there shouldn't be any breaking changes, and our experimental package usage was already aligned more or less with the 1.21 interface.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.1 milestone Nov 3, 2023
@adriansmares adriansmares self-assigned this Nov 3, 2023
@github-actions github-actions bot added c/network server This is related to the Network Server c/gateway server This is related to the Gateway Server c/application server This is related to the Application Server security This is important for security compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file tooling Development tooling labels Nov 3, 2023
@github-actions github-actions bot removed the c/application server This is related to the Application Server label Nov 3, 2023
@adriansmares adriansmares marked this pull request as ready for review November 3, 2023 12:15
CHANGELOG.md Outdated Show resolved Hide resolved
@adriansmares adriansmares merged commit 7936e19 into v3.28 Nov 3, 2023
13 checks passed
@adriansmares adriansmares deleted the feature/go-1.21 branch November 3, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway server This is related to the Gateway Server c/network server This is related to the Network Server compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file security This is important for security tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants