Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase gateway identifiers limit #6683

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

adriansmares
Copy link
Contributor

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1003

Changes

  • Increase the limit of gateway identifiers in the assert rights call to 100 entities, as batch gateway stats RPC allows up to 100 entities.
    • The limit for the batch deletion can stay at 20, and in line with the batch device end deletion limits.

Testing

N/A. This is just an API definition change - take a look at the generated code for review purposes.

No explicit testing is required.

Regressions

This handles a regression in itself. I would say that allowing 100 entities in an RPC which is guaranteed to be served by the read replica is acceptable and fine.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.1 milestone Nov 2, 2023
@adriansmares adriansmares self-assigned this Nov 2, 2023
@adriansmares adriansmares marked this pull request as ready for review November 2, 2023 16:24
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@adriansmares adriansmares merged commit 89059b4 into v3.28 Nov 3, 2023
16 checks passed
@adriansmares adriansmares deleted the fix/api-limits-mismatch branch November 3, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants