Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip membership chains check if no entities are to be checked #6668

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1003

Changes

  • Deduplicate gateway identifiers before attempting to retrieve the gateways (otherwise we detect that one gateway was not found, which is wrong).
  • Skip the membership chains check if no entities are to be checked.

Testing

Local testing using the steps from the original issue.

Regressions

N/A.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Nov 1, 2023
@adriansmares adriansmares added this to the v3.28.1 milestone Nov 1, 2023
@adriansmares adriansmares self-assigned this Nov 1, 2023
@github-actions github-actions bot added the c/identity server This is related to the Identity Server label Nov 1, 2023
@adriansmares adriansmares marked this pull request as ready for review November 1, 2023 15:37
@adriansmares adriansmares merged commit 8f61cd8 into v3.28 Nov 1, 2023
12 of 13 checks passed
@adriansmares adriansmares deleted the fix/single-stats branch November 1, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/identity server This is related to the Identity Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants