Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console protocol authentication and rate limiting #6667

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Console protocol authentication and rate limiting #6667

merged 2 commits into from
Nov 2, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References #6653

Changes

  • Allow the bearer token to be provided as a protocol, similar to kubernetes/kubernetes@714f97d
  • Add rate limiting for subscribe/unsubscribe requests.

Testing

Local testing. No explicit testing is required.

Regressions

All of the changes are new and the internal Console API is currently unused.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.1 milestone Nov 1, 2023
@adriansmares adriansmares self-assigned this Nov 1, 2023
@github-actions github-actions bot added c/console This is related to the Console ui/web This is related to a web interface labels Nov 1, 2023
@adriansmares adriansmares marked this pull request as ready for review November 1, 2023 15:11
KrishnaIyer
KrishnaIyer approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

ryaplots
ryaplots approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code owned lgtm

@adriansmares adriansmares merged commit a172724 into v3.28 Nov 2, 2023
14 of 15 checks passed
@adriansmares adriansmares deleted the feature/ws-auth branch November 2, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryaplots ryaplots ryaplots approved these changes

@johanstokking johanstokking johanstokking approved these changes

@KrishnaIyer KrishnaIyer KrishnaIyer approved these changes

@kschiffer kschiffer Awaiting requested review from kschiffer

@mjamescompton mjamescompton Awaiting requested review from mjamescompton

Assignees

@adriansmares adriansmares

Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Milestone
v3.28.1
Development

Successfully merging this pull request may close these issues.
4 participants
@adriansmares @KrishnaIyer @johanstokking @ryaplots