Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DevAddr filter based on NetID configuration #6649

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

johanstokking
Copy link
Member

Summary

Fixes the DevAddr that PBA uses for subscribing as home network when there's only a NetID configured.

Changes

  • The prefix length is now based on the NwkAddr bits instead of the NwkID bits.

Testing

None, we don't have unit testing for this. The code is taken from Network Server.

Regressions

None, this is a bugfix.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the v3.28.1 milestone Oct 20, 2023
@johanstokking johanstokking added the size/small This should not be a lot of work label Oct 20, 2023
@johanstokking johanstokking self-assigned this Oct 20, 2023
@github-actions github-actions bot added the c/packet broker agent This is related to Packet Broker Agent label Oct 20, 2023
@johanstokking johanstokking merged commit f3238ff into v3.28 Oct 23, 2023
@johanstokking johanstokking deleted the fix/pba-devaddr branch October 23, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/packet broker agent This is related to Packet Broker Agent size/small This should not be a lot of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants