Add transmission settings set flags generation #6640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds set flags generation to a number of API messages, in order to allow the
simulate application-uplink
to work.Historically our
TxSettings
message was not nullable, so it was not possible for therequired
validation to fail, and also we did not validate the frequency (now we do). This allowed thesimulate application-uplink
to work in a very simple manner by skipping the transmission settings completely.After the
gogoproto
removal and the new validation changes, the command is not really usable because it is not possible to set the transmission settings. This PR fixes that.Changes
TxSettings
,DataRate
andNetworkIdentifiers
messages.Testing
Tested locally with the following command:
It generates the following simulated uplink:
Manual testing should repeat the same procedure (with your own application and end device ID). It should be possible to use the CLI against older stack versions too.
Help flags before and after. Before:
After:
Regressions
By looking at the
_flags.pb.go
files, recursively only theApplicationUplink.SetFromFlags
is affected, and we use that setter only for thesimulate application-uplink
command, so things should be fine.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.