Make forwarder information part of the gateway uplink tokens #6630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reference https://github.com/packetbroker/router/issues/109
Changes
Testing
Unit testing. On
staging1
just checking that Packet Broker still works suffices.Regressions
We did not have a release yet which uses the new optimized format, so adding the additional data won't break anything.
Notes for Reviewers
Are there situations during routing in which the forwarder information changes ? I am specifically afraid of a forwarder publishing their traffic, without a tenant ID let's say, and the router somewhere in its bowels adds this tenant ID while routing the message to the home network.
I am asking this because it would be problematic while receiving a routed downlink message since the forwarder additional data would be different (we used an empty string while sealing the token, but we are now trying to unseal it with another tenant ID being in there).
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.