Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make forwarder information part of the gateway uplink tokens #6630

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Oct 11, 2023

Summary

Reference https://github.com/packetbroker/router/issues/109

Changes

  • The forwarder information (net ID, tenant ID and cluster ID) is now part of the signature of the encrypted gateway tokens.

Testing

Unit testing. On staging1 just checking that Packet Broker still works suffices.

Regressions

We did not have a release yet which uses the new optimized format, so adding the additional data won't break anything.

Notes for Reviewers

Are there situations during routing in which the forwarder information changes ? I am specifically afraid of a forwarder publishing their traffic, without a tenant ID let's say, and the router somewhere in its bowels adds this tenant ID while routing the message to the home network.

I am asking this because it would be problematic while receiving a routed downlink message since the forwarder additional data would be different (we used an empty string while sealing the token, but we are now trying to unseal it with another tenant ID being in there).

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.0 milestone Oct 11, 2023
@adriansmares adriansmares self-assigned this Oct 11, 2023
@github-actions github-actions bot added the c/packet broker agent This is related to Packet Broker Agent label Oct 11, 2023
@adriansmares adriansmares marked this pull request as ready for review October 11, 2023 10:56
@adriansmares adriansmares merged commit 1840a82 into v3.28 Oct 12, 2023
@adriansmares adriansmares deleted the feature/additional-data branch October 12, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/packet broker agent This is related to Packet Broker Agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants