Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert (some) class components to functional components #6579

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Convert (some) class components to functional components #6579

merged 1 commit into from
Oct 2, 2023

Conversation

kschiffer
Copy link
Contributor

@kschiffer kschiffer commented Sep 28, 2023 •
edited
Loading

Summary

This quickfix PR converts some class components to functional components.

References #6376

Changes

  • Convert class to functional components

Notes for Reviewers

Doing this to get rid of decorators that are preceding export statements, which causes issues when applying codemods.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface labels Sep 28, 2023
@kschiffer kschiffer added this to the v3.28.0 milestone Sep 28, 2023
@kschiffer kschiffer self-assigned this Sep 28, 2023
@github-actions github-actions bot removed the c/console This is related to the Console label Sep 28, 2023
mjamescompton
mjamescompton approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mjamescompton mjamescompton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update copyright in pkg/webui/components/navigation/side/index.js

pkg/webui/lib/components/intl-helmet.js Outdated Show resolved Hide resolved
@kschiffer kschiffer force-pushed the fix/class-to-functional branch from 8b6e3ed to 73312ea Compare September 29, 2023 10:43
@kschiffer kschiffer force-pushed the fix/class-to-functional branch from 73312ea to ab6c324 Compare September 30, 2023 12:39
@kschiffer kschiffer merged commit 50c1d6e into v3.28 Oct 2, 2023
@kschiffer kschiffer deleted the fix/class-to-functional branch October 2, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryaplots ryaplots ryaplots approved these changes

@mjamescompton mjamescompton mjamescompton approved these changes

Assignees

@kschiffer kschiffer

Labels
technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kschiffer @mjamescompton @ryaplots