Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.12 #521

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Upgrade to Go 1.12 #521

merged 2 commits into from
Apr 12, 2019

Conversation

htdvisser
Copy link
Contributor

@htdvisser htdvisser commented Apr 10, 2019 •
edited by rvolosatovs
Loading

Summary:

This PR is a new attempt at #192: upgrading to Go 1.12.

Changes:

  • Upgrade the Go version in documentation and Travis. I'm not bumping the minimum version requirement in our Mage files, as Go 1.11 can still be used for development.

Release Notes:

  • Bumped our Go version to 1.12

@htdvisser htdvisser added the c/shared This is shared between components label Apr 10, 2019
@htdvisser htdvisser added this to the April 2019 milestone Apr 10, 2019
@htdvisser htdvisser requested a review from johanstokking April 10, 2019 12:33
@htdvisser htdvisser self-assigned this Apr 10, 2019
@htdvisser htdvisser requested a review from KrishnaIyer April 12, 2019 07:00
KrishnaIyer
KrishnaIyer approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally with Go 1.12 and it works.

DEVELOPMENT.md
@@ -18,7 +18,7 @@ On Ubuntu (or on Windows [using the Windows Subsystem for Linux](https://www.mic
curl -sL https://deb.nodesource.com/setup_10.x | sudo -E bash -
sudo apt-get install -y build-essential nodejs

curl -sSL https://dl.google.com/go/go1.11.5.linux-amd64.tar.gz | sudo tar -xz -C /usr/local
curl -sSL https://dl.google.com/go/go1.12.3.linux-amd64.tar.gz | sudo tar -xz -C /usr/local
Copy link
Member

@KrishnaIyer KrishnaIyer Apr 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this would be 1.12.4.. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really needed. 1.12.4 fixes an issue related to cgo, which we don't use.

@htdvisser htdvisser merged commit 89cc0e6 into master Apr 12, 2019
@htdvisser htdvisser deleted the fix/go-1.12 branch April 12, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrishnaIyer KrishnaIyer KrishnaIyer approved these changes

@johanstokking johanstokking Awaiting requested review from johanstokking

Assignees

@htdvisser htdvisser

Labels
c/shared This is shared between components
Projects
None yet
Milestone
April 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@htdvisser @KrishnaIyer