-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protoc and Go dependencies #2573
Update protoc and Go dependencies #2573
Conversation
blocking #2568 |
f529af4
to
88ae547
Compare
88ae547
to
b6ee330
Compare
pkg/errors/web/middleware_test.go
Outdated
"details": [ | ||
{ | ||
"type_url": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails", | ||
"value": "Cg5wa2cvZXJyb3JzL3dlYhoJTm90IEZvdW5kIhgKFgoHbWVzc2FnZRILGglOb3QgRm91bmQ4BQ==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't right. We need to render ErrorDetails as JSON, otherwise the console won't understand it.
Alright, as far as I understand the latest gogo protobuf version is not compatible with protobuf At least now we can actually see what breaks in the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression tests like this are fine with me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Summary
Regular dependency update
Refs #2417 (comment)
Changes
Checklist
README.md
. The target branch is set tomaster
if the changes are fully compatible with existing API, database, configuration and CLI.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.