Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc and Go dependencies #2573

Merged

Conversation

rvolosatovs
Copy link
Contributor

Summary

Regular dependency update
Refs #2417 (comment)

Changes

  • Update protoc
  • Update Go dependencies
  • Adapt to upstream changes
  • Refactor and fix web error middleware tests

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
  • Testing: The changes are covered with unit tests. The changes are tested manually as well.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@rvolosatovs rvolosatovs added the dependencies Pull requests that update a dependency file label May 19, 2020
@rvolosatovs rvolosatovs added this to the May 2020 milestone May 19, 2020
@rvolosatovs rvolosatovs requested a review from htdvisser May 19, 2020 18:33
@rvolosatovs rvolosatovs self-assigned this May 19, 2020
@rvolosatovs rvolosatovs added bump/minor Needs new minor version for release compat/api This could affect API compatibility blocking Another issue or pull request is waiting for this labels May 19, 2020
@rvolosatovs
Copy link
Contributor Author

blocking #2568

@rvolosatovs rvolosatovs mentioned this pull request May 19, 2020
6 tasks
@rvolosatovs rvolosatovs force-pushed the feature/update-dependencies branch 3 times, most recently from f529af4 to 88ae547 Compare May 19, 2020 19:15
@rvolosatovs rvolosatovs force-pushed the feature/update-dependencies branch from 88ae547 to b6ee330 Compare May 19, 2020 19:16
"details": [
{
"type_url": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
"value": "Cg5wa2cvZXJyb3JzL3dlYhoJTm90IEZvdW5kIhgKFgoHbWVzc2FnZRILGglOb3QgRm91bmQ4BQ=="
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right. We need to render ErrorDetails as JSON, otherwise the console won't understand it.

@rvolosatovs
Copy link
Contributor Author

rvolosatovs commented May 20, 2020

Alright, as far as I understand the latest gogo protobuf version is not compatible with protobuf 1.4.x, so reverted the protobuf update.
I guess this particular issue can be fixed by just writing custom JSON encoding logic, but we never know what else might break, so better safe than sorry. (e.g. gogo/protobuf#686 gogo/protobuf#678 )

At least now we can actually see what breaks in the test.

@rvolosatovs rvolosatovs requested a review from htdvisser May 20, 2020 10:17
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests like this are fine with me

Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rvolosatovs rvolosatovs merged commit f1b2c06 into TheThingsNetwork:develop May 20, 2020
@rvolosatovs rvolosatovs deleted the feature/update-dependencies branch May 20, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Another issue or pull request is waiting for this bump/minor Needs new minor version for release compat/api This could affect API compatibility dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants