Merge pull request #6662 from TheThingsNetwork/release/v3.28.0

Release v3.28.0

CHANGELOG.md

@@ -23,7 +23,7 @@ For details about compatibility between different releases, see the **Commitment
 
 ### Security
 
-## [3.28.0] - unreleased
+## [3.28.0] - 2023-10-31
 
 ### Added
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ttn-stack",
-  "version": "3.27.2",
+  "version": "3.28.0",
   "description": "The Things Stack",
   "main": "index.js",
   "repository": "https://github.com/TheThingsNetwork/lorawan-stack.git",

pkg/events/batch/batch.go

@@ -41,7 +41,7 @@ func (bp *batchPublisher) process(ctx context.Context) error {
 		flushed := false
 		for n := len(batch); n >= lowerBound; n = len(batch) {
 			toFlush := n
-			if upperBound := 2 * lowerBound; n > upperBound {
+			if upperBound := 2 * bp.targetSize; n > upperBound {
 				toFlush = upperBound
 			}
 			select {

pkg/networkserver/grpc_asns.go

@@ -105,7 +105,10 @@ func (ns *NetworkServer) processApplicationUplinkTask(ctx context.Context, consu
 			}
 			cl := ttnpb.NewNsAsClient(conn)
 			if err := ns.sendApplicationUplinks(ctx, cl, ups...); err != nil {
-				log.FromContext(ctx).WithError(err).Error("Failed to send application uplinks")
+				log.FromContext(ctx).WithError(err).Warn("Failed to send application uplinks")
+				if !retryableUplinkError(err) {
+					return nil
+				}
 				return err
 			}
 			return nil

pkg/networkserver/utils.go

@@ -412,10 +412,6 @@ func (ns *NetworkServer) submitApplicationUplinks(ctx context.Context, ups ...*t
 	))
 	if err := ns.uplinkSubmissionPool.Publish(ctx, ups); err != nil {
 		log.FromContext(ctx).WithError(err).Warn("Failed to enqueue application uplinks in submission pool")
-		if nonRetryableUplinkError(err) {
-			log.FromContext(ctx).Warn("Error is non-retryable, dropping application uplinks")
-			return
-		}
 		ns.enqueueApplicationUplinks(ctx, ups...)
 		return
 	}
@@ -430,8 +426,7 @@ func (ns *NetworkServer) handleUplinkSubmission(ctx context.Context, ups []*ttnp
 	}
 	if err := ns.sendApplicationUplinks(ctx, ttnpb.NewNsAsClient(conn), ups...); err != nil {
 		log.FromContext(ctx).WithError(err).Warn("Failed to send application uplinks to Application Server")
-		if nonRetryableUplinkError(err) {
-			log.FromContext(ctx).Warn("Error is non-retryable, dropping application uplinks")
+		if !retryableUplinkError(err) {
 			return
 		}
 		ns.enqueueApplicationUplinks(ctx, ups...)
@@ -471,12 +466,10 @@ var (
 	}
 )
 
-func nonRetryableUplinkError(err error) bool {
-	return errors.IsFailedPrecondition(err) ||
+func retryableUplinkError(err error) bool {
+	return errors.IsCanceled(err) ||
+		errors.IsDeadlineExceeded(err) ||
 		errors.IsResourceExhausted(err) ||
 		errors.IsAborted(err) ||
-		errors.IsUnauthenticated(err) ||
-		errors.IsPermissionDenied(err) ||
-		errors.IsUnimplemented(err) ||
-		errors.IsInternal(err)
+		errors.IsUnavailable(err)
 }

sdk/js/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ttn-lw",
-  "version": "3.27.2",
+  "version": "3.28.0",
   "description": "The Things Stack for LoRaWAN JavaScript SDK",
   "url": "https://github.com/TheThingsNetwork/lorawan-stack/tree/default/sdk/js",
   "main": "dist/index.js",