Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change contactState values to lowercase #848

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Change contactState values to lowercase #848

merged 2 commits into from
Nov 19, 2024

Conversation

KrishnaIyer
Copy link
Member

Summary

Change contactState values to lowercase

Changes

  • Change contactState values to lowercase.

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

Refs: https://github.com/TheThingsIndustries/lorawan-stack/pull/4450

Release Notes

  • Changed the allowed values for action.contactState of normalized payloads to lowercase.

@KrishnaIyer KrishnaIyer self-assigned this Nov 19, 2024
@KrishnaIyer
Copy link
Member Author

https://github.com/TheThingsNetwork/lorawan-devices/actions/runs/11909901665/job/33188228146?pr=848#step:6:3191
So we should then update the normalizer here for the specific device right?

@johanstokking
Copy link
Member

https://github.com/TheThingsNetwork/lorawan-devices/actions/runs/11909901665/job/33188228146?pr=848#step:6:3191 So we should then update the normalizer here for the specific device right?

Yes, make validate needs to pass.

@johanstokking johanstokking merged commit 4bdce9f into master Nov 19, 2024
3 checks passed
@johanstokking johanstokking deleted the fix/casing branch November 19, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants