Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused functions crashing the decoder #841

Merged

Conversation

peter-quandify
Copy link
Contributor

Summary

Removed unused functions that were accidentally causing the decoder to crash.

Changes

Removed unused functions

  • hexToDecArray
  • base64ToDecArray

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

Release Notes

@peter-quandify
Copy link
Contributor Author

Ready for merge

@Jaime-Trinidad
Copy link
Contributor

Hi @peter-quandify please update the branch so I can merge it. Thanks

@peter-quandify peter-quandify force-pushed the cubicmeter-1.1-crash-fix branch from d86e13b to 51e8a3c Compare November 15, 2024 08:06
@Jaime-Trinidad Jaime-Trinidad merged commit c6ddfa2 into TheThingsNetwork:master Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants