Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TEKTELIC Stork and Breeze Devices #761

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

ssharma-tektelic
Copy link
Contributor

Summary

Added TEKTELIC Stork and Breeze devices.

Changes

Modified existing TEKTELIC files to include addition of Stork and Breeze devices, and created new codecs and profiles for these new devices.

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • vendorProfileID should not be vendorID.
  • All devices should be listed in the vendor's index.yaml file.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one comment

bin/validate.js Outdated Show resolved Hide resolved
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to resolve the diff in bin/validate.js by adding an empty line in the bottom.

vendor/tektelic/t0007806-864-profile.yaml Outdated Show resolved Hide resolved
vendor/tektelic/t0007806-864-profile.yaml Outdated Show resolved Hide resolved
@johanstokking johanstokking merged commit dd1b90c into TheThingsNetwork:master Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants