Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rate limiting HTTP improvements documentation #1218

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add rate limiting HTTP improvements documentation #1218

merged 1 commit into from
Nov 21, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References TheThingsNetwork/lorawan-stack#6714

Screenshots

image

Changes

  • Document the fact that URL classes exist now.
  • Document the fact that caller identity is used instead of IP, when available.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@adriansmares adriansmares added this to the Nov 2023 milestone Nov 20, 2023
@adriansmares adriansmares self-assigned this Nov 20, 2023
@adriansmares adriansmares marked this pull request as ready for review November 20, 2023 16:18
KrishnaIyer
KrishnaIyer approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansmares adriansmares force-pushed the feature/rate-limit-extensions branch from dfedd0d to 3cdfc91 Compare November 21, 2023 11:47
@adriansmares adriansmares merged commit 61815b6 into master Nov 21, 2023
1 check passed
@adriansmares adriansmares deleted the feature/rate-limit-extensions branch November 21, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrishnaIyer KrishnaIyer KrishnaIyer approved these changes

Assignees

@adriansmares adriansmares

Labels
None yet
Projects
None yet
Milestone
Nov 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansmares @KrishnaIyer