v6.1.0 #337
Merged
v6.1.0 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this wont require the entire directory just to use 1 driver
docgen interferes with this, since running only docgen doesnt load logger
according to the documentation, this should allow this job to run on tags as well as on new commits
* Update commands.md * typo
this command throws fatal typeerrors inside the imgflipper module, replacing this soon with something hopefully not terrible
docs didnt like it
* Small changes to make things more understandable * Update en-EN.json * Update en-EN.json
linuswillner
requested changes
Aug 18, 2018
src/commands/join-voice.js
Outdated
| @@ -39,38 +39,38 @@ module.exports = { | |||
| } | |||
| } else { | |||
| resolveTracks(suffix).then(tracks => { | |||
There was a problem hiding this comment.
For improved code quality and readability, perhaps name the callback variable trackInfo and cast trackInfo.tracks to a constant. This is a nitpick, but tracks.tracks is not very descriptive and more confusing than anything else.
src/commands/request.js
Outdated
| @@ -36,40 +36,38 @@ module.exports = { | |||
| } | |||
| } else { | |||
| resolveTracks(suffix).then(tracks => { | |||
There was a problem hiding this comment.
My suggestion for join-voice applies here as well.
src/commands/urbandictionary.js
Outdated
| @@ -35,9 +35,10 @@ module.exports = { | |||
| } | |||
| }) | |||
| } else { | |||
| msg.channel.createMessage(`<@${msg.author.id}>, ${suffix}: This word is so screwed up, even Urban Dictionary doesn't have it in its database`) | |||
| msg.channel.createMessage(`<@${msg.author.id}>, ${suffix}: This word is so screwed up, even UrbanDictionary doesn't have it in its database`) | |||
There was a problem hiding this comment.
Name mangling issue here. According to Wikipedia, the name is in fact Urban Dictionary.
There was a problem hiding this comment.
Hah, accidentally changed this with my last commit, will fix.
src/internal/logger.js
Outdated
| @@ -64,7 +64,8 @@ module.exports = { | |||
| sendToES({ | |||
| type: 'command', | |||
| cmd: opts.cmd, | |||
| full: opts.cmd + ' ' + opts.opts, | |||
| // full: opts.cmd + ' ' + opts.opts, | |||
There was a problem hiding this comment.
Commented out code should not be left in the production build.
* Fixed the command documentation generator never going out of temp state * Improved documentation for certain commands
There was a lack of parity between the CI and development environment scripts for command docgen, causing a condition where the command documentation would fail to build properly in development.
superagent doesnt like unescaped characters at all
linuswillner
approved these changes
Aug 20, 2018
This commit fixes current code to work with Lavalink v3 as well as with FFmpeg.
zaza7
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the changelog for a full list of changes