Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tls map #105

Merged
merged 3 commits into from
Feb 26, 2023
Merged

add tls map #105

merged 3 commits into from
Feb 26, 2023

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Feb 26, 2023

Description

add https://github.com/noraj/tls-map / https://github.com/noraj/tls-map

Related issues

N/A

Point of attention

N/A

@noraj noraj changed the title Noraj/tls map tls map Feb 26, 2023
@noraj noraj changed the title tls map add tls map Feb 26, 2023
@ShutdownRepo ShutdownRepo changed the base branch from main to dev February 26, 2023 00:37
@ShutdownRepo
Copy link
Member

As indicated in #102, #103 and #104, please use dev branch.

@ShutdownRepo ShutdownRepo added the new tool(s) This adds one or multiple tools to Exegol label Feb 26, 2023
@noraj
Copy link
Contributor Author

noraj commented Feb 26, 2023

As indicated in #102, #103 and #104, please use dev branch.

I focused to base my PR on dev branch but forgot to target dev branch while creating the PR.

@ShutdownRepo
Copy link
Member

Please sync with dev branch in order to update this PR so that the right workflows are triggered

@noraj
Copy link
Contributor Author

noraj commented Feb 26, 2023

Please sync with dev branch in order to update this PR so that the right workflows are triggered

I don't understand, I'm already in sync

image

image

@ShutdownRepo
Copy link
Member

ShutdownRepo commented Feb 26, 2023 •
edited
Loading

Hmm can you do any other change to the PR? Like change the order of two lines in the history file
This will update the PR and trigger the right workflow. Since you first created the PR from main branch, it’s been triggering the wrong ones.

@noraj noraj requested a review from ShutdownRepo February 26, 2023 00:54
@ShutdownRepo ShutdownRepo self-assigned this Feb 26, 2023
@ShutdownRepo ShutdownRepo merged commit 681f8be into ThePorgs:dev Feb 26, 2023
@noraj noraj deleted the noraj/tls-map branch February 26, 2023 14:20
@noraj
Copy link
Contributor Author

noraj commented Feb 26, 2023

Thanks for the review and guidelines for the 1st contributions.

@ShutdownRepo
Copy link
Member

Sure thing! Thanks for the contrib!

@ShutdownRepo ShutdownRepo mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShutdownRepo ShutdownRepo ShutdownRepo approved these changes

Assignees

@ShutdownRepo ShutdownRepo

Labels
new tool(s) This adds one or multiple tools to Exegol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noraj @ShutdownRepo