Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang 18 support #1614

Closed
diath opened this issue Jul 6, 2024 · 1 comment
Closed

Clang 18 support #1614

diath opened this issue Jul 6, 2024 · 1 comment

Comments

@diath
Copy link

diath commented Jul 6, 2024 •
edited
Loading

It seems like Sol no longer works on the newest Clang release:

sol/function_types.hpp:110:31: error: address of overloaded function 'call' does not match required type 'int (lua_State *)'
  110 |                                 lua_CFunction freefunc = &function_detail::upvalue_this_member_variable<C, Fx>::template call<is_yielding, no_trampoline>;
@diath
Copy link
Author

diath commented Jul 6, 2024

Nevermind, I didn't search the issues, this is a duplicate:
#1581
#1560
#1588

@diath diath closed this as completed Jul 6, 2024
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
ea79af0 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
f65d545 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
8f422ab 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
0dc189a 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
7c76c97 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
d28296c 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
b8e9ab1 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
9d7c38a 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
ensisoft added a commit to ensisoft/detonator that referenced this issue Oct 11, 2024
@ensisoft
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc
50bef74 
Upgrade to Emscripten💩 3.1.50 in order to enable mimalloc.

The default allocator (dlmalloc) has dog-shit for performance
under multiple threads due to plenty of locking happening inside
the allocator. The better allocator is mimalloc that requires
Emscripten💩 3.1.50

Emscripten💩 3.1.27 changed the default stack size to 64kb.
Restore the original 5MB stack size with

  -sSTACK_SIZE=5MB

Upgrading Emscripten comes with a new clang that is based on
a new LLVM version that has a regression so sol2 build fails:
ThePhD/sol2#1614

Adding a WAR in sol.hpp to change the offendin function signatures
to unconditonal noexcept.

mimalloc performance:
emscripten-core/emscripten#20651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diath