Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More resources & ores from GCyR planets #939

Merged
merged 22 commits into from
Nov 10, 2024

Conversation

Xefyr0
Copy link
Collaborator

@Xefyr0 Xefyr0 commented Oct 14, 2024

This PR is intended to make GCyR planets worth more than a 1-time visit, boost ore veins of materials people struggle to get, and clean up related script files.

  • Cleanup and unify GT vein scripts
  • Make Fluorite vein also generate in Normal Mode
  • Increased yield of Chromite veins in The End
  • Added Chromite to Magnetite/Gold veins on Luna
  • Added fluid veins to all planets
  • Added equivalent to Moon Dust for all planets, expanded centrifuging products for all variants

I have started work on collection & distillation of planetary atmospheres as well, but the materials they would provide are far more effectively acquired through other means. Let me know if this is something that's desired or if mining & pumping on other planets is sufficient.

@MightyPiggie
Copy link
Contributor

Would it be an idea to increase the weight of realgar? Currently they are a pain to get in the early stages of the game. And when you find a vein you only get tiny amount of them.
image

@Xefyr0
Copy link
Collaborator Author

Xefyr0 commented Oct 16, 2024

Yeah I've noticed that people have been struggling with Arsenic - hopefully making it appear more often in its own vein should help.

Don't forget that Cobaltite also works as a source, though!

EDIT: Arsenic is planned to be made more common in the next Gregtech: Modern update.
Thus, this PR no longer alters its frequency.

This causes errors in KJS or other difficult-to-troubleshoot issues,
so we first update this old file to something nonfunctional as you see here
and THEN delete it in the next patch after.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xefyr0 Does that mean it would also work when someone skips the two updates? Otherwise, I'm afraid it wouldn't happen as rarely as we might think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it wouldn't.

It was an attempt to mitigate the problems that arose when people updated the modpack as per this suggestion, but I don't think I'm going to continue with the idea since:

  1. It's a problem with launchers, and trying to fix it from our end will require a lot of extra work
  2. Any effort we put in to fix it on our end won't matter if someone makes a mistake in one commit
  3. CF launchers do not have this issue (Prism too, as of the 9.0 update)

So I'm thinking the best way forward is to forego this approach and encourage people to switch launchers if they have this issue in the future

@Xefyr0 Xefyr0 marked this pull request as draft October 24, 2024 13:11
@Xefyr0 Xefyr0 marked this pull request as ready for review November 6, 2024 15:13
@Xefyr0 Xefyr0 changed the title Ore vein improvements More resources & ores from GCyR planets Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants