Fix enderio redstone conduits for some blocks #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xefyr0
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Minor nitpick: event.add can work with an array in the second parameter to apply the tag to every item in the array, removing the need for the forEach. so for example, you could assign the array to the variable "list" and after the definition simply go
event.add('enderio:redstone_connectable', list)
|
Thx, I wasn't aware it was possible to provide an array, it's indeed better and most likely more efficient since it reduces JS<->Java transactions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we wait for a fix from EnderIO (see Team-EnderIO/EnderIO#852 (comment))
