Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working/upgrade without legacy peer deps #42

Merged
merged 53 commits into from
Jan 13, 2025

Conversation

PoorBillyPilgrim
Copy link
Contributor

Description

Major updates and/or replacements to several key packages. Notably, the project now uses React 18 and Next.js 15. All older tests using enzyme have been removed or replaced with jest. The dependency tree was also cleaned up which no longer required --legacy-peer-deps when installing.

Motivation and Context

These updates removed any identifiable security vulnerabilities and any new functionality can be built without the worry of using older or deprecated libraries.

How Has This Been Tested?

Tests were updated to account for package updates or replacements.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

…-legacy-provider`.

- Some constraints version constraints are too narrow, so `npm install`
  will not succeed without `--legacy-peer-dependencies`.
- Webpack 4 uses `md4` hash, which is not supported by OpenSSL 3, which
  is used in Node 17+.
Since, `next` 10.0.4`, we should use `productionBrowserSourceMaps`, if
we want source maps beyond dev mode.
- Stop at `typescript` v4.7.4, since v4.8+ has checks that will break
  the code right now.
- Also, `useUnknownInCatchVariables` began defaulting to `true` sometime
  after `typescript` v4.3.4, so we turn it off to prevent errors from our
  untyped `catch` variables.
tdilauro and others added 23 commits April 5, 2024 14:43
* docker build working with npm install
* --legacy-peer-deps flag no longer needed
* started refactoring tests to account for updated ariakit (reakit replacement) and swr
* disabled some type checking
* bumped Typescript to v4.8.4 and resolved some type errors
* migrated msw to 2.6.5
* migrated babel-jest to 29.7.0
* upgrade fetch-mock
* remove fetch-mock-jest
* upgrade node to v20 lts so that we could upgrade opds-feed-parser to latest version
@PoorBillyPilgrim PoorBillyPilgrim added the dependencies Pull requests that update a dependency file label Dec 2, 2024
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 🚀

I was able to build and run from docker container, so I'm going to approve this one and merge it.

@tdilauro tdilauro merged commit 5218deb into main Jan 13, 2025
4 checks passed
@tdilauro tdilauro deleted the working/upgrade-without-legacy-peer-deps branch January 13, 2025 01:38
@PoorBillyPilgrim
Copy link
Contributor Author

Great, thanks @tdilauro for wading through all these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants