-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working/upgrade without legacy peer deps #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-legacy-provider`. - Some constraints version constraints are too narrow, so `npm install` will not succeed without `--legacy-peer-dependencies`. - Webpack 4 uses `md4` hash, which is not supported by OpenSSL 3, which is used in Node 17+.
Since, `next` 10.0.4`, we should use `productionBrowserSourceMaps`, if we want source maps beyond dev mode.
- Stop at `typescript` v4.7.4, since v4.8+ has checks that will break the code right now. - Also, `useUnknownInCatchVariables` began defaulting to `true` sometime after `typescript` v4.3.4, so we turn it off to prevent errors from our untyped `catch` variables.
* docker build working with npm install * --legacy-peer-deps flag no longer needed * started refactoring tests to account for updated ariakit (reakit replacement) and swr * disabled some type checking
* bumped Typescript to v4.8.4 and resolved some type errors * migrated msw to 2.6.5 * migrated babel-jest to 29.7.0
* upgrade fetch-mock * remove fetch-mock-jest
* upgrade node to v20 lts so that we could upgrade opds-feed-parser to latest version
PoorBillyPilgrim
added
the
dependencies
Pull requests that update a dependency file
label
Dec 2, 2024
tdilauro
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! 🚀
I was able to build and run from docker container, so I'm going to approve this one and merge it.
Great, thanks @tdilauro for wading through all these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Major updates and/or replacements to several key packages. Notably, the project now uses React 18 and Next.js 15. All older tests using enzyme have been removed or replaced with jest. The dependency tree was also cleaned up which no longer required
--legacy-peer-deps
when installing.Motivation and Context
These updates removed any identifiable security vulnerabilities and any new functionality can be built without the worry of using older or deprecated libraries.
How Has This Been Tested?
Tests were updated to account for package updates or replacements.
Checklist: