Upgrade to Node 18.

[ray-lee]

Description

Upgrades this project to build with Node 18, along with some other quality/security improvements. This includes:

• Upgrading dependencies that were incompatible with Node 18
• Upgrading dependencies to resolve npm audit security errors (not all of them, just the easy ones for now)
• Code/configuration changes required by major version upgrades of dependencies, including
  • Major typescript update required adding some missing type parameters to Promise constructors
  • Major webpack update required updating some webpack config files, moving some npm script arguments into webpack config files, and removing some no-longer-supported arguments
• Some minor formatting changes to resolve lint errors
• Additional exports from some files to resolve documentation generation warnings

Motivation and Context

The project had been using Node 12, which is no longer supported, and will not be allowed in GitHub actions soon. Notion: https://www.notion.so/lyrasis/Upgrade-web-opds-client-to-Node-18-44f9a03cbb0545cc863f19a5db8bb9c0

How Has This Been Tested?

• Verify that npm install runs without error
• Verify that all npm scripts in all package.json files (package.json, packages/server/package.json, and packages/web-opds-client/package.json) run without error (except for npm publish, which we'll test when we actually publish). This especially includes npm test in packages/web-opds-client.
• Verify that the app runs in dev:
  • npm run dev
  • Open http://localhost:3000 in a browser
  • Enter a feed URL, e.g. https://cerberus.tpp-qa.lyrasistechnology.org/cerberus-test-1/feed/1206
  • Verify the feed is displayed

Checklist:

• I have updated the documentation accordingly.
• All new and existing tests passed.

[tdilauro]

This looks good and seems to work fine.

I do have one question about the husky dependency being reverted to an older version. Could you clarify?

[tdilauro]

Just adding a not of explanation here for future reference that with lint-staged v10 and above, the "git add" can be omitted. From the docs:

From v10.0.0 onwards any new modifications to originally staged files will be automatically added to the commit. If your task previously contained a git add step, please remove this. The automatic behaviour ensures there are less race-conditions, since trying to run multiple git operations at the same time usually results in an error.

[tdilauro]

Explanation: "expand" behavior was the default before v0.22. For v0.22+, "resolve" behavior is the default. We're updating from v0.20... to v0.23..., so this change is to retain the "expand" behavior.

From the docs:

The default behavior in v0.21 and earlier. Behaves like the resolve behavior, but will recursively expand directories into an entry point for each file within the directory.

[ray-lee]

@tdilauro Could you approve this? I think everything has been resolved.

[tdilauro]

Looks good! 🚀