Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ISBN lookup to identifier module. (PP-1948) #2196

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Nov 27, 2024

Description

Moves identifier ISBN lookup to the identifier module.

Motivation and Context

[Jira PP-1948]

How Has This Been Tested?

  • Tests pass locally.
  • CI tests for associated branch pass.

Checklist

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from a team November 27, 2024 03:09
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (c741d34) to head (df8204c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2196   +/-   ##
=======================================
  Coverage   91.09%   91.09%           
=======================================
  Files         363      363           
  Lines       41248    41248           
  Branches     8839     8839           
=======================================
  Hits        37575    37575           
  Misses       2406     2406           
  Partials     1267     1267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@tdilauro tdilauro merged commit 102e9f6 into main Nov 27, 2024
21 checks passed
@tdilauro tdilauro deleted the chore/move-isbn-lookup branch November 27, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants