Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename collection library associations. (PP-1875) #2195

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Nov 26, 2024

Description

  • Rename some collection/library association attributes.
  • Still to do: Some renaming from the library side.

Motivation and Context

With the introduction of the subscription concept, it would be helpful to clearly make the distinction between (1) all configured associations between Collections and Librarys and (2) those that are currently in effect or active.

This PR separates out some of the renaming of the existing association attributes to both

  • simplify the review process, and
  • reduce the time that a PR with such sweeping changes is in flight, hopefully reducing conflicts amongst PRs.

[Jira PP-1875]

How Has This Been Tested?

Checklist

  • N/A I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good generally, but I put a comment about renaming the association_proxy on IntegrationConfiguration that I'd like to discuss before it goes in.

src/palace/manager/sqlalchemy/model/integration.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (6f25265) to head (15cafd5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/palace/manager/scripts/configuration.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2195      +/-   ##
==========================================
+ Coverage   91.08%   91.09%   +0.01%     
==========================================
  Files         363      363              
  Lines       41221    41248      +27     
  Branches     8843     8839       -4     
==========================================
+ Hits        37545    37575      +30     
+ Misses       2407     2406       -1     
+ Partials     1269     1267       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdilauro tdilauro force-pushed the chore/rename-collection-library-associations branch from 70629da to aad0972 Compare November 26, 2024 21:54
@tdilauro tdilauro merged commit c741d34 into main Nov 26, 2024
21 checks passed
@tdilauro tdilauro deleted the chore/rename-collection-library-associations branch November 26, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants