Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move custom lists pydantic model into models package #2187

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

jonathangreen
Copy link
Member

Description

Move the custom lists controllers pydantic models into the palace.manager.api.admin.model package.

Motivation and Context

I moved these while working on #2186 because I thought I would be able to reuse them. Turns out the work editor uses different data, so I couldn't reuse them. I think it makes sense though to move these, so they are with the rest of the admin controller pydantic models.

How Has This Been Tested?

  • Running tests

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team November 22, 2024 17:48
@jonathangreen jonathangreen changed the base branch from main to bugfix/works-customlist-library November 22, 2024 17:50
@jonathangreen jonathangreen force-pushed the chore/move-custom-lists-model branch from 99289a5 to 65195bc Compare November 22, 2024 17:51
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.03%. Comparing base (64b5368) to head (d5ceeb8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   90.93%   91.03%   +0.10%     
==========================================
  Files         362      363       +1     
  Lines       41222    41225       +3     
  Branches     8850     8850              
==========================================
+ Hits        37487    37531      +44     
+ Misses       2441     2421      -20     
+ Partials     1294     1273      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️

Base automatically changed from bugfix/works-customlist-library to main November 22, 2024 20:15
@jonathangreen jonathangreen force-pushed the chore/move-custom-lists-model branch from 65195bc to d5ceeb8 Compare November 22, 2024 20:16
@jonathangreen jonathangreen merged commit 8d10cab into main Nov 22, 2024
21 checks passed
@jonathangreen jonathangreen deleted the chore/move-custom-lists-model branch November 22, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants