[PP-1914] Remove collection facet from feed. #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernstein
force-pushed
the
PP-1914-remove-collection-facet
branch
from
2cef11b to
f833605
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2182 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 361 361
Lines 41205 41172 -33
Branches 8849 8840 -9
=======================================
- Hits 37504 37474 -30
+ Misses 2425 2424 -1
+ Partials 1276 1274 -2 ☔ View full report in Codecov by Sentry. |
jonathangreen
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
This looks good!
We also need a follow up PR for this, that will go into the release after this one to clean the old settings out of our existing library configurations. They won't cause any issues, but its good to clean them out of the json field before we forget about them.
jonathangreen
added
the
cleanup migration
2 tasks
|
Follow-on PR here: #2204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update removes the Collection Facet and all related artifacts from the code base.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1914
How Has This Been Tested?
Unit tests have been updated.
Checklist