Replace sqlalchemy backref parameter with back_populates #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
chore/replace-backref
branch
from
e8966b1 to
ce4f7eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore/mypy-config-tests #2123 +/- ##
========================================================
Coverage 90.73% 90.74%
========================================================
Files 351 351
Lines 40904 40934 +30
Branches 8874 8871 -3
========================================================
+ Hits 37115 37146 +31
Misses 2481 2481
+ Partials 1308 1307 -1 ☔ View full report in Codecov by Sentry. |
jonathangreen
force-pushed
the
chore/replace-backref
branch
from
ce4f7eb to
7e3628b
Compare
tdilauro
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
The changes to tests/manager/api/controller/test_work.py don't seem strictly necessary, but I don't see any problem with them.
There was a problem hiding this comment.
Hmm... I forget why i changed this file... maybe for mypy? I'm not sure now, i guess i should have put a comment on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates all references to
backrefto useback_populatesas sqlalchmey recommends as the current best practice. This PR also tweaks some of the flags we use for mypy only in our tests, to disable some of the mypy warnings that aren't very meaningful for tests.Motivation and Context
The sqlalchemy
backrefparameter is considered legacy see: https://docs.sqlalchemy.org/en/14/orm/backref.html. Using this construct means that mypy (and IDE) can't infer the type of the dynamically generated parameter.This is part of the effort to get the code to a place where we can enable
check_untyped_defsin mypy.How Has This Been Tested?
Checklist