Refactor mock webserver into a fixture #1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes two changes:
mock_web_server
into a fixture, since we use the same fixture function in a few placesrequest_with_timeout
we settimeout
,backoff_factor
, so that the tests don't have to wait for retries. This was making tests slower then they need to be.Motivation and Context
I was troubleshooting what was causing slow tests in #1554. This was not the cause, but it was making out tests take longer then they needed to, so I thought I'd fix it while I noticed since it cuts down the time to run our core tests by about a minute for me.
How Has This Been Tested?
Checklist