Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused class OPDSImportCoverageProvider (PP-313) #1393

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

jonathangreen
Copy link
Member

Description

Remove unused class OPDSImportCoverageProvider.

Motivation and Context

I was tracing code to add some type hints while working on PP-313, and noticed these classes were unused.

How Has This Been Tested?

Running tests.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team September 20, 2023 13:09
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (35e32de) 90.23% compared to head (7344af5) 90.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files         229      229           
  Lines       29906    29869   -37     
  Branches     6831     6823    -8     
=======================================
- Hits        26985    26953   -32     
+ Misses       1879     1871    -8     
- Partials     1042     1045    +3     
Files Changed Coverage Δ
core/opds_import.py 89.56% <ø> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen force-pushed the feature/remove-unused-opds-coverage-provider branch from abab69b to 25821b3 Compare September 21, 2023 00:44
@jonathangreen jonathangreen changed the title Remove unused class OPDSImportCoverageProvider Remove unused class OPDSImportCoverageProvider (PP-313) Sep 21, 2023
@jonathangreen jonathangreen force-pushed the feature/remove-unused-opds-coverage-provider branch from 25821b3 to b3ff65a Compare September 22, 2023 17:32
@jonathangreen jonathangreen force-pushed the feature/remove-unused-opds-coverage-provider branch from b3ff65a to 7344af5 Compare September 22, 2023 22:44
Copy link
Contributor

@RishiDiwanTT RishiDiwanTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jonathangreen jonathangreen merged commit e65d979 into main Oct 2, 2023
30 checks passed
@jonathangreen jonathangreen deleted the feature/remove-unused-opds-coverage-provider branch October 2, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants