Remove the unused ConfigurationStorage classes (PP-313) #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
========================================
Coverage 90.22% 90.23%
========================================
Files 229 229
Lines 29905 29713 -192
Branches 6831 6788 -43
========================================
- Hits 26983 26812 -171
+ Misses 1880 1864 -16
+ Partials 1042 1037 -5
☔ View full report in Codecov by Sentry. |
jonathangreen
force-pushed
the
feature/storage-integration
branch
from
8e4990d to
d739045
Compare
jonathangreen
force-pushed
the
feature/remove-configuration-storage
branch
from
9726c85 to
74af6ac
Compare
jonathangreen
changed the base branch from
feature/storage-integration
to
feature/remove-integration-links
jonathangreen
force-pushed
the
feature/remove-integration-links
branch
from
cf60c47 to
0696d92
Compare
jonathangreen
force-pushed
the
feature/remove-configuration-storage
branch
from
74af6ac to
294d8d0
Compare
jonathangreen
force-pushed
the
feature/remove-integration-links
branch
from
0696d92 to
1563020
Compare
jonathangreen
force-pushed
the
feature/remove-configuration-storage
branch
from
294d8d0 to
b3d16f0
Compare
jonathangreen
changed the base branch from
feature/remove-integration-links
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the ConfigurationStorage classes.
Motivation and Context
After #1377 lands, the
ConfigurationStorageclasses are now unused. Removing these classes before getting into the main work for PP-313.How Has This Been Tested?
Checklist