Add start and until date arguments to playback time reporting. (PP-273)
#1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dates are parsed into UTC, rather than naive, `datetime`s. - Factored out the query into a helper function to improve readability.
tdilauro
force-pushed
the
feature/playtime-report-date-ranges
branch
from
d5ea5d4 to
e50a646
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
=======================================
Coverage 90.12% 90.13%
=======================================
Files 219 219
Lines 29598 29626 +28
Branches 6832 6836 +4
=======================================
+ Hits 26676 26704 +28
Misses 1879 1879
Partials 1043 1043
☔ View full report in Codecov by Sentry. |
|
@jonathangreen Thanks for the feedback. Just by chance, the new tests unearthed a bug that wasn't specifically related to this PR. 😅 At any rate, this is ready for another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
startanduntildate range to playback time reporting script.Motivation and Context
Add ability to report on ad hoc date range. The default dates remain the same.
How Has This Been Tested?
Checklist