Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-411 Fix incorrectly formatted FCM notification #1361

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

RishiDiwanTT
Copy link
Contributor

Description

Fixed the fcm_admin method call, this wasn't caught during testing because fcm_admin is mocked and cannot be realistically tested in the unit tests.

Motivation and Context

The desired behaviour was not occurring after the previous fix, investigations led to the the discovery of a badly formatted API call.

How Has This Been Tested?

Manually tested the FCM notification syntax with a dev token.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@RishiDiwanTT RishiDiwanTT requested a review from a team September 8, 2023 14:15
@RishiDiwanTT RishiDiwanTT self-assigned this Sep 8, 2023
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🛠️

@RishiDiwanTT RishiDiwanTT merged commit 06dd41a into main Sep 11, 2023
30 checks passed
@RishiDiwanTT RishiDiwanTT deleted the feature/notificative-notifications branch September 11, 2023 10:30
@tdilauro tdilauro added the bug Something isn't working label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants