Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the directory importer script 🔥 (PP-213) #1345

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

jonathangreen
Copy link
Member

Description

Remove the directory importer script, since we are not using it anywhere, and have decided to host content like this elsewhere in the future.

Motivation and Context

Our database migration for #1189 failed on the Columbia staging server because it had an external integration configured with “Manual intervention“ as the protocol. This collection was added via the directory_import script. This script appears to create collections that cause problems with the new integration settings system.

Instead of fixing this issue, we've decided to remove the script.

How Has This Been Tested?

Running tests.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d7d3d87) 89.90% compared to head (d4bf373) 89.90%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1345    +/-   ##
========================================
  Coverage   89.90%   89.90%            
========================================
  Files         212      211     -1     
  Lines       28644    28459   -185     
  Branches     6538     6497    -41     
========================================
- Hits        25752    25586   -166     
+ Misses       1886     1881     -5     
+ Partials     1006      992    -14     
Files Changed Coverage Δ
api/admin/controller/settings.py 80.10% <ø> (-0.06%) ⬇️
core/model/configuration.py 91.96% <ø> (-0.02%) ⬇️
scripts.py 84.97% <ø> (ø)
core/metadata_layer.py 87.91% <100.00%> (-0.18%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen changed the title Remove the directory importer script (PP-213) Remove the directory importer script 🔥 (PP-213) Aug 29, 2023
@jonathangreen jonathangreen requested a review from a team August 30, 2023 00:23
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🔥

@jonathangreen jonathangreen merged commit 13513bc into main Aug 31, 2023
@jonathangreen jonathangreen deleted the feature/remove-directory-importer branch August 31, 2023 21:49
@tdilauro tdilauro added the incompatible changes Changes that require a new major version label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible changes Changes that require a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants