-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove locally hosted LCP Collections 🔥 (PP-393) #1344
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
==========================================
+ Coverage 89.92% 90.01% +0.09%
==========================================
Files 211 204 -7
Lines 28475 28051 -424
Branches 6499 6458 -41
==========================================
- Hits 25605 25250 -355
+ Misses 1880 1822 -58
+ Partials 990 979 -11
☔ View full report in Codecov by Sentry. |
3f37a2a
to
a0cac0d
Compare
a0cac0d
to
85525ff
Compare
85525ff
to
662ad2b
Compare
🚨 The migration on this one has gotten stale and will need to be synced up with main before merging. Just leaving this as a note to myself so I make sure that happens before merging. This still should be fine for code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Does this removal of code not affect the lcp passphrase that gets added to the OPDS feeds in api/opds.py
?
It should not change the addition of that lcp passphrase, since that is used for LCP content that is hosted by other providers, as well as locally hosted LCP content. So we will still need that element in the feed to support other LCP providers like Palace Marketplace. |
Description
Remove locally hosted LCP collections from the CM, since we are not using it anywhere.
NOTE: This does NOT impact LCP content hosted by other vendors, but borrowed through the CM. Just CM hosted LCP collections, which are not being used anywhere currently.
Motivation and Context
As part of PP-95, the LCP mirror integration needs some updating. Since we are not using this anywhere, and it does not appear to be working currently, we decided to remove it rather then fix it.
How Has This Been Tested?
Checklist