Update to make it easier to get problem detail

core/app_server.py

@@ -217,10 +217,9 @@ def handle(self, exception: Exception) -> Response | HTTPException:
 
         # Try to turn the exception into a useful HTTP error response.
         if isinstance(exception, (RemoteIntegrationException, ProblemError)):
-            if isinstance(exception, RemoteIntegrationException):
-                document = exception.as_problem_detail_document(self.debug)
-            else:
-                document = exception.problem_detail
+            # This exception can be turned directly into a problem
+            # detail document.
+            document = exception.problem_detail
 
             if not self.debug:
                 document.debug_message = None

core/util/http.py

@@ -68,6 +68,10 @@ def as_problem_detail_document(self, debug):
             debug_message=self.document_debug_message(debug),
         )
 
+    @property
+    def problem_detail(self):
+        return self.as_problem_detail_document(debug=False)
+
 
 class BadResponseException(RemoteIntegrationException):
     """The request seemingly went okay, but we got a bad response."""

tests/core/util/test_http.py

@@ -381,6 +381,16 @@ def test_as_problem_detail_document(self):
             == document.debug_message
         )
 
+        # We can also use the problem_detail property to get the same result
+        document_from_property = exception.problem_detail
+        assert document.uri == document_from_property.uri
+        assert document.title == document_from_property.title
+        assert document.status_code == document_from_property.status_code
+
+        # But problem_detail is always the non-debug version, so the debug_message is not present
+        assert document.debug_message != document_from_property.debug_message
+        assert document_from_property.debug_message is None
+
 
 class TestRequestTimedOut:
     def test_as_problem_detail_document(self):