Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storage services component (PP-95) #87

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jonathangreen
Copy link
Member

@jonathangreen jonathangreen commented Sep 13, 2023

Description

Remove the storage services configuration from the admin UI.

Motivation and Context

As part of PP-95, the CM is moving storage service configuration out to be configured with environment variables. The CM part of this PR is forthcoming, but this means that the admin UI no longer needs to show options for storage service configuration.

How Has This Been Tested?

  • Running unit tests in CI

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen
Copy link
Member Author

Draft CM PR this is related to: ThePalaceProject/circulation#1377

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Looks good!

@jonathangreen jonathangreen merged commit f465eaa into main Sep 19, 2023
@jonathangreen jonathangreen deleted the feature/remove-storage-integrations branch September 19, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants