Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark password field as required #73

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Mark password field as required #73

merged 2 commits into from
Feb 13, 2023

Conversation

io7m
Copy link
Contributor

@io7m io7m commented Feb 9, 2023

Description

The CM now considers passwords to be required and not optional. This updates the UI so that the password field shows the "Required" text.

Motivation and Context

See: ThePalaceProject/circulation#801

How Has This Been Tested?

I just checked the form in the web interface. All of the real changes happened in the CM.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@io7m
Copy link
Contributor Author

io7m commented Feb 9, 2023

Eyeing test failure.

@io7m io7m requested a review from a team February 9, 2023 14:25
Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 🎸

Ideally, we'd be disabling the the Submit button when the updates are not valid, but I think that's more involved and should not be part of this work.

@io7m io7m merged commit 8305c3a into main Feb 13, 2023
@io7m io7m deleted the passwords-required branch February 13, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants