Upgrade jsdom to version 20. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades JSDOM to version 20, and makes the necessary changes to successfully compile and run (almost all of the) tests.
There is one test failure that remains, due to the DOM not allowing a file input value to be changed programatically. This test is currently being skipped, but it should be fixed in the future.
Motivation and Context
This was needed to add jest and react testing library to the project. It also gets us to a modern version of JSDOM that matches the one used in other JS projects.
How Has This Been Tested?
All unit tests (except the one, which is currently being skipped) have been updated, and pass.
Checklist: