Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove borrow button from catalog list view. #56

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

ray-lee
Copy link
Contributor

@ray-lee ray-lee commented Nov 18, 2022

Description

This removes the Borrow button from the catalog list view. It upgrades opds-web-catalog to 1.0.0, which allows us to show or hide the circulation links by setting a prop.

Before:
Screen Shot 2022-11-18 at 10 45 58 AM

After:
Screen Shot 2022-11-18 at 10 46 28 AM

Motivation and Context

The circulation functions are complicated to support in the admin UI, and there is no built-in reader, so we are removing them.

Notion: https://www.notion.so/lyrasis/Hide-Borrow-button-when-viewing-titles-in-list-view-after-opening-a-lane-in-the-Collection-Manager-b00a7e7bac244b57a6abf2a737f42510

How Has This Been Tested?

In the catalog, click on a lane, and click the list view button at the top. No Borrow buttons should appear in the list, as in the above screenshot.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@ray-lee ray-lee marked this pull request as ready for review November 18, 2022 16:06
@ray-lee ray-lee requested a review from a team November 18, 2022 16:06
Copy link
Contributor

@RishiDiwanTT RishiDiwanTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succinct 👍

@ray-lee ray-lee merged commit 704202c into main Nov 28, 2022
@ray-lee ray-lee deleted the remove_borrow_button branch November 28, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants