Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circulation links from book details. #23

Merged
merged 2 commits into from
May 10, 2022
Merged

Remove circulation links from book details. #23

merged 2 commits into from
May 10, 2022

Conversation

ray-lee
Copy link
Contributor

@ray-lee ray-lee commented May 2, 2022

Description

This removes the circulation links (Borrow, Download, Read buttons) from the book details page. The count of copies available is retained.

I previously mentioned making this change in a fork of NYPL-Simplified/opds-web-client, but I realized that there was a good way to do it in just this repo.

Screenshot:
borrow-removed

Motivation and Context

This reduces unneeded complexity in the Admin UI, as there is no in-browser reader for EPUB books.

Notion: https://www.notion.so/lyrasis/Hide-Borrow-button-from-Admin-User-accounts-68fbcb4d0a3f44fc942a247a7bc08e40

How Has This Been Tested?

  • Open some book details, using users with different permission levels.
  • Verify that for all books and all users, there is no "Borrow", "Download", or "Read" button above the number of copies available.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@ray-lee ray-lee requested a review from a team May 2, 2022 22:09
Copy link
Contributor

@RishiDiwanTT RishiDiwanTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ray-lee ray-lee merged commit 31fb540 into main May 10, 2022
@ray-lee ray-lee deleted the remove-borrow branch May 10, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants