Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce modern context provider and hooks (PP-1572) #123

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Aug 7, 2024

Description

Adds context hooks for many of the properties provided by the current, legacy context provider in the ContextProvider component. With this change, the ContextProvider component injects a provider for the new AppContext into the component tree, so we don't need to account for another component in the app tree or in test wrappers.

Motivation and Context

  • Provide a migration path away from legacy context provider.
  • Make it easier to write some business logic hooks.

[Jira PP-1572]

How Has This Been Tested?

  • Manually tested locally with the dev-server.
  • New and existing tests pass locally. Existing tests did not need to be modified.
  • CI tests for associated branch passed.

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee August 7, 2024 18:17
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 This looks like a good way to migrate to modern context.

@tdilauro tdilauro merged commit ffdd3f0 into main Aug 9, 2024
1 check passed
@tdilauro tdilauro deleted the chore/introduce-modern-context branch August 9, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants