Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce React Toolkit. #113

Merged
merged 3 commits into from
May 30, 2024
Merged

Introduce React Toolkit. #113

merged 3 commits into from
May 30, 2024

Conversation

tdilauro
Copy link
Contributor

Description

  • Introduces React Toolkit.
  • Migrates store configuration to RTK.
  • Moves most of our Redux imports to RTK.
    • The notable exception is src/reducers/index.ts which showed errors when importing combineReducers from RTK, rather than "redux".

Motivation and Context

  • Gives us the ability to incrementally simplify and modernize the codebase.

How Has This Been Tested?

  • Some manual testing.
  • All automated tests pass.

Checklist:

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee May 29, 2024 19:58
tdilauro
tdilauro commented May 29, 2024
View reviewed changes
src/store.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the real changes happen here, where we create a function to configure the store, and in the package files.

All of the rest of the changes are just moving imports.

Copy link
Contributor Author

@tdilauro tdilauro May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Here" is src/store.ts.

@tdilauro tdilauro requested review from a team, dbernstein and jonathangreen and removed request for ray-lee and a team May 30, 2024 02:25
jonathangreen
jonathangreen approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get deeply into understanding the change here, but it looks good to me!

@tdilauro tdilauro merged commit 542a0b9 into main May 30, 2024
1 check passed
@tdilauro tdilauro deleted the feature/introduce-react-toolkit branch May 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathangreen jonathangreen jonathangreen approved these changes

@dbernstein dbernstein Awaiting requested review from dbernstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdilauro @jonathangreen