Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some GitHub action versions. (PP-1285) #111

Merged
merged 1 commit into from
May 24, 2024

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented May 20, 2024

Description

  • Updates the versions of some GitHub actions in our workflows.
  • Also allows the Test workflow run on any push, rather than just on PRs.

Motivation and Context

I was having some trouble with hangs on the test.yml workflow and I was also seeing errors like this in the workflow logs:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[Jira PP-1285]

How Has This Been Tested?

  • Some testing locally with act v0.2.62.
  • Some parts need to be verified on GitHub.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested review from jonathangreen and ray-lee May 20, 2024 20:36
Copy link
Member

@jonathangreen jonathangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tdilauro tdilauro merged commit 3421013 into main May 24, 2024
1 check passed
@tdilauro tdilauro deleted the feature/upgrade-github-actions branch May 24, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants