Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Jira's own icons from the alt verification #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Exclude Jira's own icons from the alt verification #24

wants to merge 1 commit into from

Conversation

patrickhlauke
Copy link
Contributor

Jira's own icons for things like cross-references currently lack an alt attribute, leading to false positives when running the "Verify Alts" functionality. This explicitly excludes these (identified by their icon class) from the check.

@patrickhlauke patrickhlauke requested a review from basiphobe May 21, 2020 18:14
@patrickhlauke
Copy link
Contributor Author

Before - various false positives for the various viewavatar missing alt (currently null

before

After - those false positives are now not showing up anymore

after

@patrickhlauke
Copy link
Contributor Author

just a ping before i disappear ... @stevefaulkner @basiphobe

@stevefaulkner
Copy link

thanks @patrickhlauke, @basiphobe can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevefaulkner stevefaulkner stevefaulkner approved these changes

@basiphobe basiphobe Awaiting requested review from basiphobe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhlauke @stevefaulkner