-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Ruby Automated Testing Introduction Lesson #22449
Feature: Ruby Automated Testing Introduction Lesson #22449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really really really good man! I just saw minor minor nitpicks on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall!
I know it looks like a lot, but it's mostly just super small nit-picky grammar things. I have a feeling a lot of these might actually be American vs UK English differences. Please ignore any you don't agree with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few grammatical issues others have pointed out, but otherwise LGTM.
48bee16
to
d25cc4f
Compare
Thanks for all the feedback @ZachBaird, @wise-king-sullyman and @leosoaivan. It's very much appreciated 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last small thing that looks like it got a bit mixed up doing the changes, then it's approve-city.
|
||
Depending on the size of the project, it could take anywhere from a few minutes to a few weeks in order to exhaustively test everything manually. This amount of time only increases as the project grows in size and complexity. | ||
|
||
On the flip side, automated tests take a fraction of the time to run, often only seconds. And you only need to write an automated test once, after which it will test that behavior every time the test suite is run as opposed to having to repeatedly testing the same thing manually every time a change is made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the flip side, automated tests take a fraction of the time to run, often only seconds. And you only need to write an automated test once, after which it will test that behavior every time the test suite is run as opposed to having to repeatedly testing the same thing manually every time a change is made. | |
On the flip side, automated tests take a fraction of the time to run, often only seconds. And you only need to write an automated test once, after which it will test that behavior every time the test suite is run as opposed to repeatedly testing the same thing manually every time a change is made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 🎯 thanks dude.
Because: * We are writing a new section about automated testing in the Ruby course and this lesson will serve as the introduction to that section. It's purpose is to provide the big picture about automated tests and why they are important.
d25cc4f
to
ed96f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for putting up with me!
@wise-king-sullyman it wasn't a problem mate, all this feedback has been great. The lesson reads sooo much better now. Thanks for taking the time to review this everyone, I appreciate you all 😄 |
Because: