Added support for virtual machines in addition to devices #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For virtual machines it uses platforms instead of device_type :)) |
Closed
|
I'll close this PR due to the progress in #30 and the branch which has been added for testing purpose. But thanks for your contribution, i used some parts of your code as inspiration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for virtual machines in addition to the existing device functionality, as most of my infrastructure is based on VMs. I also included an option in the config.py file to allow users to choose whether to ignore devices or virtual machines based on their needs.
I'm not great at coding, so it could probably be improved a bit.