Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker-compose.yml and updated documentation #65

Closed
wants to merge 7 commits into from

Conversation

Kage1
Copy link
Contributor

@Kage1 Kage1 commented Jun 13, 2024

Added docker-compose.yml as proposed by the owner and updated the readme to reflect the new file with usage instructions.

Kage1 added 6 commits June 12, 2024 09:33
Added docker compose example
Docker Compose file for running the netbox-zabbix-sync
Revised with references to the docker-compose.yml file in the repo.
@TheNetworkGuy
Copy link
Owner

Could you edit the location of the config file to .config.py instead of the /opt/netbox-zabbix? Not everyone will have the script running in that directory so it makes more sense to include the file from the directory in which both files are found. Since this is also the case in the Git repo :)

@Kage1
Copy link
Contributor Author

Kage1 commented Jun 17, 2024

Could you edit the location of the config file to .config.py instead of the /opt/netbox-zabbix? Not everyone will have the script running in that directory so it makes more sense to include the file from the directory in which both files are found. Since this is also the case in the Git repo :)

The portion of the docker-compose volume map after the colon : is the internal map to the docker container which is mapped to /opt/netbox-zabbix. This is where the file lives in the docker container.

The host file system could be updated to reference the same directory where the compose file is run at.

@Kage1
Copy link
Contributor Author

Kage1 commented Jun 17, 2024

I'm not very good with dealing with PR's... Do I need to close this one and create a new PR or is there a way to update this one to include the updated compose file?

Edit: Looks like after the edit it's now showing up in the PR.

@TheNetworkGuy
Copy link
Owner

I'll close this PR for now due to work on several other branches and a plan to completely renew the documentation as stated in #66. Thanks nontheless for your PR but right now i need more help for testing other milestones such as #30 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants