Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding no_std feature #288

Merged
merged 2 commits into from
May 21, 2024
Merged

adding no_std feature #288

merged 2 commits into from
May 21, 2024

Conversation

dscso
Copy link
Contributor

@dscso dscso commented May 20, 2024

Reorganizing Cargo.toml to get it compiling in a no_std environment

@TheNeikos
Copy link
Owner

Heya! Looks good to me, do you think you could also sign-off your commit?

Should be a simple git commit --amend --signoff --no-edit and then push your branch again.

@dscso
Copy link
Contributor Author

dscso commented May 20, 2024

I hope this is ok, I had some difficulties :)

To simplify the feature set for users this commit refactors the feature
list as thus:

- mqttv5, which does not require std
- mqttv3, which currently does require std
- std, which enables/disables the `no_std` in lib.rs

Both `mqttv3` and `mqttv5` are enabled per default. Once `mqttv3` no
longer requires `std` this can then be further refined and the whole
crate made no_std. Downstream users should mostly care about mqttv3/5
and not about the std-ness.

Signed-off-by: Marcel Müller <[email protected]>
@TheNeikos TheNeikos merged commit 666db95 into TheNeikos:main May 21, 2024
9 of 10 checks passed
@TheNeikos
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants