-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sa 2336 update jc template import #353
Merged
jworkmanjc
merged 36 commits into
JumpCloudModule_1.19.0
from
SA-2336-Update-JCTemplate-Import
Mar 7, 2022
Merged
Sa 2336 update jc template import #353
jworkmanjc
merged 36 commits into
JumpCloudModule_1.19.0
from
SA-2336-Update-JCTemplate-Import
Mar 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs added with manager lookup using username instead of userId
…/TheJumpCloud/support into SA-2330-Update-JcUser-Attributes
…-2330-Update-JcUser-Attributes
commit
…Cloud/support into SA-2336-Update-JCTemplate-Import
…Cloud/support into SA-2336-Update-JCTemplate-Import
jworkmanjc
commented
Mar 1, 2022
gweinjc
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good
kmaranionjc
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
The alternateEmail, manager & managedAppleID fields were missing from the New/Get/Set-JCUser, Import/Update-JCUsersFromCSV & New-JCImportTemplate functions - this release adds those fields to those functions.
Is there anything particularly tricky?
The manager field is a bit interesting. Keeping in line with how we've set other functions in the JCModule, the manager field will accept a string input of either an ID or a username. If a username is provided the function will do a lookup and determine the correct manager ID, if an ID is provided the function will add the manager field to the user object.
How should this be tested?
Get-JCUser:
Get-JCUser -username "someUser"
should return all alternateEmail, manager, managedAppleID attributesGet-JCUser -userid "someUserid"
should return all alternateEmail, manager, managedAppleID attributesSet-JCUser:
Set-JCUser -username "someUser"
can set all alternateEmail, manager, managedAppleID attributesNew-JCuser:
New-JCImportTemplate
Import-JCUserFromCSV
Update-JCUserFromCSV
Screenshots