Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sa 2336 update jc template import #353

Merged
merged 36 commits into from
Mar 7, 2022

Conversation

jworkmanjc
Copy link
Contributor

Issues

  • SA-2336 - Import/Update-JCUsersFromCSV & New-JCImportTemplate: alternateEmail, manager, managedAppleID attributes
  • SA-2330 - New/Get/Set-JCUser: alternateEmail, manager, managedAppleID attributes

What does this solve?

The alternateEmail, manager & managedAppleID fields were missing from the New/Get/Set-JCUser, Import/Update-JCUsersFromCSV & New-JCImportTemplate functions - this release adds those fields to those functions.

Is there anything particularly tricky?

The manager field is a bit interesting. Keeping in line with how we've set other functions in the JCModule, the manager field will accept a string input of either an ID or a username. If a username is provided the function will do a lookup and determine the correct manager ID, if an ID is provided the function will add the manager field to the user object.

How should this be tested?

Get-JCUser:

  • Test that Get-JCUser -username "someUser" should return all alternateEmail, manager, managedAppleID attributes
  • Test that Get-JCUser -userid "someUserid" should return all alternateEmail, manager, managedAppleID attributes
    Set-JCUser:
  • Test that Set-JCUser -username "someUser" can set all alternateEmail, manager, managedAppleID attributes
  • Test that `Set-JCUser -userid "someUserid" can set all alternateEmail, manager, managedAppleID attributes
    New-JCuser:
  • Test that running New-JCUser can add a user and set the alternateEmail, manager, managedAppleID attributes
    New-JCImportTemplate
  • Running this function should produce a csv with the alternateEmail, manager, managedAppleID attributes
    Import-JCUserFromCSV
  • New users can be added with alternateEmail, manager, managedAppleID attributes
    Update-JCUserFromCSV
  • Existing users can be updated and their alternateEmail, manager, managedAppleID attributes can be set

Screenshots

kmaranionjc and others added 24 commits February 22, 2022 08:39
…rs added with manager lookup using username instead of userId
…Cloud/support into SA-2336-Update-JCTemplate-Import
…Cloud/support into SA-2336-Update-JCTemplate-Import
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@jworkmanjc jworkmanjc merged commit 0c9a470 into JumpCloudModule_1.19.0 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants